Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CXL host exerciser segmentation fault non-root user mode #3066

Closed
wants to merge 1 commit into from
Closed

fix: CXL host exerciser segmentation fault non-root user mode #3066

wants to merge 1 commit into from

Conversation

anandaravuri
Copy link
Contributor

-CXL host exerciser segmentation fault occurs in non-root user mode,
exit application if clx device open fails.

  • CXL host exerciser running pointer tests show wrong "data ping pong tests", Change to "Running pointer test started ......"

@anandaravuri
fix: CXL host exerciser segmentation fault non-root user mode
3d6865b 
 -CXL host exerciser  segmentation fault occurs in non-root user mode,
  exit application if clx device open fails.
 - CXL host exerciser  running pointer tests show wrong "data ping pong tests",
   Change to "Running pointer test started ......"

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri anandaravuri requested a review from a team as a code owner January 4, 2024 19:01
fpgamatt
fpgamatt reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@fpgamatt fpgamatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate this into to two commits. Change the commit message regarding segmentation fault of non-root user to something like "properly handle failing to open device file".

pcolberg
pcolberg previously approved these changes Jan 4, 2024
View reviewed changes
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7413692300

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 65.191%
Totals Coverage Status
Change from base Build 7399670798: -0.003%
Covered Lines: 15756
Relevant Lines: 24169
💛 - Coveralls

@pcolberg
Copy link
Contributor

pcolberg commented Jan 4, 2024 •
edited

@anandaravuri Is there a reason not to reuse this PR? You can force-push the two separated commits to the same branch, then merge with Rebase and merge to preserve them in the master branch. (Maybe for next time, since you already opened successor PRs, #3067 and #3068.)

KrishnaSimmadhari
KrishnaSimmadhari reviewed Jan 5, 2024
View reviewed changes
Copy link

@KrishnaSimmadhari KrishnaSimmadhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpgamatt fpgamatt fpgamatt left review comments

@KrishnaSimmadhari KrishnaSimmadhari KrishnaSimmadhari left review comments

@pcolberg pcolberg pcolberg left review comments

@pl-ravikanth pl-ravikanth Awaiting requested review from pl-ravikanth

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anandaravuri @coveralls @pcolberg @fpgamatt @KrishnaSimmadhari