Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:improve fpgametrics output readability and #3075

Merged
merged 2 commits into from Jan 17, 2024

Conversation

anandaravuri
Copy link
Contributor

  • update fpga metrics index numbered from 1-42 (instead of 0-41)
  • improve fpgametrics output readability
  • group power and thermal sensor strings and values

  - update fpga metrics index numbered from 1-42 (instead of 0-41)
  - improve fpgametrics  output readability
  - group power and thermal sensor strings and values

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandaravuri! Is there any benefit to moving from 0-based to 1-based indexing? Is it for consistency with other indexed output?

@anandaravuri
Copy link
Contributor Author

Thanks @anandaravuri! Is there any benefit to moving from 0-based to 1-based indexing? Is it for consistency with other indexed output?

current fpgametrics output display Sensor details numbering 0 to 39 ( starting from 0)

 metric_num              qualifier_name                    metric_name              value

0 | thermal_mgmt:Board Temperature #2 | Board Temperature #2 | 44.50 Celsius
1 | thermal_mgmt:FPGA FABRIC Max Temperature | FPGA FABRIC Max Temperature | 42.50 Celsius
2 | thermal_mgmt:FPGA Core A (SDM) Temperature [Remote] | FPGA Core A (SDM) Temperature [Remote] | 66.50 Celsius

Fix:fpgametrics output display Sensor details index 1 to 40


 metric_num              qualifier_name                    metric_name              value

1 | thermal_mgmt:Board Temperature #2 | Board Temperature #2 | 44.50 Celsius
2 | thermal_mgmt:FPGA FABRIC Max Temperature | FPGA FABRIC Max Temperature | 42.50 Celsius
3 | thermal_mgmt:FPGA Core A (SDM) Temperature [Remote] | FPGA Core A (SDM) Temperature [Remote] | 66.50 Celsius

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7559621910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 64.846%

Totals Coverage Status
Change from base Build 7547756072: -0.001%
Covered Lines: 15790
Relevant Lines: 24350

💛 - Coveralls

@anandaravuri anandaravuri merged commit 05d88ab into master Jan 17, 2024
26 of 27 checks passed
@anandaravuri anandaravuri deleted the aravuri/fix_fpgamatrics branch January 17, 2024 20:24
anandaravuri added a commit that referenced this pull request Jan 22, 2024
- update fpga metrics index numbered from 1-42 (instead of 0-41)
  - improve fpgametrics  output readability
  - group power and thermal sensor strings and values

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
anandaravuri added a commit that referenced this pull request Jan 22, 2024
- update fpga metrics index numbered from 1-42 (instead of 0-41)
  - improve fpgametrics  output readability
  - group power and thermal sensor strings and values

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants