Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hssi: set sbd properties to enumerate fpga device and set sbdf prope… #3103

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

anandaravuri
Copy link
Contributor

@anandaravuri anandaravuri commented Feb 14, 2024

…rties to enumerate afu

Set PCIe segment, bus, and device properties to enumerate FPGA DEVICE (FME)
Set PCIe segment, bus, device, and function properties to enumerate FPGA ACCELERATOR

hssi hssi_10g works fine,
hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. #3094

Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

@coveralls
Copy link

coveralls commented Feb 14, 2024

Pull Request Test Coverage Report for Build 7919669269

Details

  • -2 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 64.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/afu-test/afu_test.h 1 3 33.33%
Totals Coverage Status
Change from base Build 7880120507: -0.006%
Covered Lines: 15809
Relevant Lines: 24450

💛 - Coveralls

Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anandaravuri! Could you explain in the commit message why this change is needed, i.e., what was broken before and how does reparsing the PCIe address resolve the issue?

@anandaravuri
Copy link
Contributor Author

Thanks @anandaravuri! Could you explain in the commit message why this change is needed, i.e., what was broken before and how does reparsing the PCIe address resolve the issue?

hssi hssi_10g works fine,
hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. #3094

Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

@pcolberg
Copy link
Contributor

Thanks @anandaravuri, could you update the PR description accordingly?

…ties to enumerate afu

 Set PCIe segment, bus, and device properties to enumerate FPGA DEVICE (FME)
 Set PCIe segment, bus, device, and function properties to enumerate FPGA ACCELERATOR

 hssi hssi_10g works fine,
 hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. #3094

 Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri anandaravuri merged commit b993ce2 into master Feb 15, 2024
27 checks passed
@anandaravuri anandaravuri deleted the aravuri/fix_hssi branch February 15, 2024 19:25
anandaravuri added a commit that referenced this pull request Feb 15, 2024
…ties to enumerate afu (#3103)

Set PCIe segment, bus, and device properties to enumerate FPGA DEVICE (FME)
 Set PCIe segment, bus, device, and function properties to enumerate FPGA ACCELERATOR

 hssi hssi_10g works fine,
 hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. #3094

 Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
anandaravuri added a commit that referenced this pull request Feb 20, 2024
…ties to enumerate afu (#3103) (#3105)

Set PCIe segment, bus, and device properties to enumerate FPGA DEVICE (FME)
 Set PCIe segment, bus, device, and function properties to enumerate FPGA ACCELERATOR

 hssi hssi_10g works fine,
 hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. #3094

 Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants