host_exerciser:support no FPGA mgmt PF instances #3108

anandaravuri · 2024-02-21T19:33:54Z

Issue: The host exerciser fails to execute on Devkits if it does not support FPGA management PF. The host exerciser enumerates FME and quits the program if the bitstream does not support it.

The I series-DK and F series-DK have multiple host exerciser AFUs on separate PCIe bus, device functions.

fix: If the bitstream does not support FME, perform the host exerciser tests and print message.

host_exerciser --pci-address 0000:03:00.2 lpbk
host_exerciser --pci-address 0000:04:00.2 lpbk

Issue: The host exerciser fails to execute on Devkits if it does not support FPGA management PF. The host exerciser enumerates FME and quits the program if the bitstream does not support it. The I series-DK and F series-DK have multiple host exerciser AFUs on separate PCIe bus, device functions. fix: If the bitstream does not support FME, perform the host exerciser tests and print message. host_exerciser --pci-address 0000:03:00.2 lpbk host_exerciser --pci-address 0000:04:00.2 lpbk opae.io ls [0000:03:00.0] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.7] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: None) [0000:04:00.5] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:03:00.7] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.3] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.5] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.1] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.3] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.1] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.6] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: None) [0000:04:00.4] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.6] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.2] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:03:00.4] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.0] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.2] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) Signed-off-by: anandaravuri <ananda.ravuri@intel.com>

coveralls · 2024-02-21T19:47:27Z

Pull Request Test Coverage Report for Build 8007037196

Details

-6 of 28 (78.57%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 64.688%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/afu-test/afu_test.h	22	28	78.57%

Totals
Change from base Build 7981504925:	0.03%
Covered Lines:	15820
Relevant Lines:	24456

💛 - Coveralls

pcolberg

Thanks @anandaravuri! A couple of minor comments below:

pcolberg · 2024-02-21T23:31:52Z

libraries/afu-test/afu_test.h

-      }
-      return exit_codes::not_found;
-    }    
+        logger_->info("Not found FPGA DEVICE");


Suggested change

logger_->info("Not found FPGA DEVICE");

logger_->info("no FPGA DEVICE found");

to be consistent with the message below.

pcolberg · 2024-02-21T23:33:19Z

libraries/afu-test/afu_test.h


    if (tokens.size() > 1) {
-      std::cerr << "more than one DEVICE found matching filter\n";
+        std::cout << "more than one FPGA DEVICE found \n";


Why does this not use logger_?

pcolberg · 2024-02-21T23:34:14Z

libraries/afu-test/afu_test.h

+  int open_handle(const char *afu_id) {
+
+    if (!enum_fpga_device()) {
+        std::cout << "Not Found FME device\n";


This will output another error message, which enum_fpga_device() already does. Why is that needed?

pcolberg · 2024-02-21T23:37:20Z

samples/host_exerciser/host_exerciser_cmd.h

+        // strange and perhaps unnecessary limitation. Therefore, future work is to
+        // fix that and clean up the code below.
+
+        if (token_device_) {


Suggested change

if (token_device_) {

if (!token_device_)

return;

to avoid one level of indentation below. As a rule of thumb, the happy path of a function should visually flow vertically, early exits horizontally; which makes it easier to reason what the main purpose of a function is (beyond the documentation).

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>

libraries/afu-test/afu_test.h

pcolberg

Thanks @anandaravuri!

* host_exerciser:support no FPGA mgmt PF instances Issue: The host exerciser fails to execute on Devkits if it does not support FPGA management PF. The host exerciser enumerates FME and quits the program if the bitstream does not support it. The I series-DK and F series-DK have multiple host exerciser AFUs on separate PCIe bus, device functions. fix: If the bitstream does not support FME, perform the host exerciser tests and print message. host_exerciser --pci-address 0000:03:00.2 lpbk host_exerciser --pci-address 0000:04:00.2 lpbk opae.io ls [0000:03:00.0] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.7] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: None) [0000:04:00.5] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:03:00.7] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.3] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.5] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.1] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.3] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.1] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.6] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: None) [0000:04:00.4] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.6] (0x8086:0xbccf 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:04:00.2] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) [0000:03:00.4] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:04:00.0] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: dfl-pci) [0000:03:00.2] (0x8086:0xbcce 0x8086:0x1771) Intel Acceleration Development Platform N6001 (Driver: vfio-pci) -------- Signed-off-by: anandaravuri <ananda.ravuri@intel.com> Co-authored-by: Peter Colberg <peter.colberg@intel.com>

anandaravuri requested review from a team as code owners February 21, 2024 19:33

anandaravuri requested review from fpgamatt, anandhv and pcolberg February 21, 2024 19:34

pcolberg reviewed Feb 21, 2024

View reviewed changes

fix code review comments

025cdc4

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>

pcolberg reviewed Feb 22, 2024

View reviewed changes

libraries/afu-test/afu_test.h Outdated Show resolved Hide resolved

Fix indentation

709aa7c

pcolberg approved these changes Feb 22, 2024

View reviewed changes

anandaravuri merged commit dfabc03 into master Feb 22, 2024
27 checks passed

anandaravuri deleted the aravuri/fix_he_fme branch February 22, 2024 16:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

host_exerciser:support no FPGA mgmt PF instances #3108

host_exerciser:support no FPGA mgmt PF instances #3108

anandaravuri commented Feb 21, 2024

coveralls commented Feb 21, 2024 •

edited

Loading

pcolberg left a comment

pcolberg Feb 21, 2024

pcolberg Feb 21, 2024

pcolberg Feb 21, 2024 •

edited

Loading

pcolberg Feb 21, 2024 •

edited

Loading

pcolberg left a comment

	logger_->info("Not found FPGA DEVICE");
	logger_->info("no FPGA DEVICE found");

host_exerciser:support no FPGA mgmt PF instances #3108

host_exerciser:support no FPGA mgmt PF instances #3108

Conversation

anandaravuri commented Feb 21, 2024

coveralls commented Feb 21, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8007037196

Details

💛 - Coveralls

pcolberg left a comment

Choose a reason for hiding this comment

pcolberg Feb 21, 2024

Choose a reason for hiding this comment

pcolberg Feb 21, 2024

Choose a reason for hiding this comment

pcolberg Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

pcolberg Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

pcolberg left a comment

Choose a reason for hiding this comment

coveralls commented Feb 21, 2024 •

edited

Loading

pcolberg Feb 21, 2024 •

edited

Loading

pcolberg Feb 21, 2024 •

edited

Loading