Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large default maximum limit for mu_star #1410

Open
pat-schmitt opened this issue Apr 7, 2022 · 3 comments
Open

Very large default maximum limit for mu_star #1410

pat-schmitt opened this issue Apr 7, 2022 · 3 comments

Comments

@pat-schmitt
Copy link
Member

I just saw that the default maximum limit for mu_star is 10000 (see https://github.com/OGGM/oggm/blob/master/oggm/params.cfg#L219), but from the explanation above I think it should be rather 1000. Or is there a reason for this large upper limit?

@pat-schmitt
Copy link
Member Author

Further, this should raise an error in mu_star_calibration_from_geodetic_mb if no limit is given (https://github.com/OGGM/oggm/blob/master/oggm/core/climate.py#L1356)

@fmaussion
Copy link
Member

Yeah the thing is that very large mus are needed when you don't allow for a temperature bias (cc @lilianschuster). Maybe something to consider for 1.6

@pat-schmitt
Copy link
Member Author

Ok thanks.

@fmaussion fmaussion reopened this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants