Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixes for dynamic mu star calibration #1451

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Aug 23, 2022

  • Tests added/passed

Some more bug fixes for run_dynamic_mu_star_calibration:

  • now properly works with cfg.PARAMS['continue_on_error'] = True, meaning do not stop execution if run_dynamic_spinup entity_task raise an error, as error management is included in run_dynamic_mu_star_calibration
  • fixed compatibility issue if different spinup strategies should be compiled together. The problem is that the fixed geometry spinup introduces an extra variable 'is_fixed_geometry_spinup' in the dataset, and to compile it together there is now an option to add this variable also to the dynamic spinup run
  • there where an issue in calibrate_inversion_from_consensus if the user provides their own volume but there is no ITMIX volume available. Now the ITMIX volume is completely ignored if the user provides a volume.
  • changed some variable names for more consistency between the two dynamic tasks

@pat-schmitt pat-schmitt merged commit a9b1817 into OGGM:master Aug 24, 2022
@pat-schmitt pat-schmitt deleted the bug_fix_dyn_mu_diagnostics branch October 4, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants