Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more flexibility to compile_run_output #1563

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Apr 6, 2023

In this PR I added more flexibility to compile_run_output. Now it is possible to compile outputs with different data variables. This is mainly needed for the new minimum thickness strategy during the dynamic melt_f calibration. But maybe could be useful in the future.

I have adapted for 2d and 3d variables (for monthly or daily hydro output) and added a test for both cases.

Closes #1561

  • Tests added/passed
  • Fully documented
  • Entry in whats-new.rst

@pat-schmitt
Copy link
Member Author

With these changes, I also could delete the kwarg make_compatible in run_until_and_store.
I introduced it to compile runs with different spinup strategies together. As fixed_geometry_spinup is the fallback for dynamic spinup and has the additional data variable is_fixed_geometry_spinup. With make_compatible I added is_fixed_geometry_spinup as a dummy data variable to all runs, even if no fixed geometry spinup is performed. This is not necessary anymore, with the larger flexibility of compile_run_output.

@fmaussion fmaussion merged commit 03248bd into OGGM:master Apr 11, 2023
@fmaussion
Copy link
Member

OK merging now to test - please add the remaing TODOs in subsequent PR

@pat-schmitt pat-schmitt deleted the adapt_compile_run_output branch April 12, 2023 06:42
@pat-schmitt pat-schmitt mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile_run_output error in prepro workflow
2 participants