Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt 2d redistribution #1619

Merged
merged 9 commits into from Aug 23, 2023
Merged

Conversation

pat-schmitt
Copy link
Member

Here I add some changes to the redistribution function, made by @afisc.

This includes:

  • thickness threshold for filtering out spikes in the area
  • rolling mean smoothing the area to avoid steps (due to the trapezoidal bed shape of the flowline)
  • monthly interpolation for a higher temporal resolution

Something to discuss is if we should use the monthly interpolation as the default. Currently, there are two different time coordinates used in gridded_data (time and time_monthly) depending on if we use monthly interpolation. This maybe could be simplified if we say we always want to use monthly time steps in the redistribution.

Additionally, I added an option for an area evolution plot (show_area_plot) for finding the best smoothing parameters for your glacier. Here are some small examples:

No smoothing:
image

With thickness threshold of 1:
image

With thickness threshold of 1 and rolling mean smoothing with window size 4:
image

These changes should also be added to the tutorials (https://oggm.org/tutorials/master/notebooks/beginner/distribute_flowline.html).

  • Tests added/passed
  • Fully documented
  • Entry in whats-new.rst

@fmaussion fmaussion merged commit 84a4d77 into OGGM:master Aug 23, 2023
27 checks passed
@pat-schmitt pat-schmitt deleted the adapt_2d_redistribution branch August 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants