Changes docs #1624
Merged
Changes docs #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaussion
reviewed
Aug 24, 2023
| As of v1.6, W5E5 is the standard dataset used by OGGM as reference. All | ||
| preprocessed directories use it. | ||
|
|
||
| TODO: explain what W5E5 is and why it is the default. |
There was a problem hiding this comment.
It would be good to add a little bit of text here. Can you add? The main reason it is the new default is that it is bias corrected for impact models and we can use ISIMIP forcing: https://www.isimip.org/
You can write a bit of text and ask be and Lily to review it maybe? Would be super helpful!
There was a problem hiding this comment.
I can make a first attempt and will ask Lily to review it :)
|
Thanks Anouk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the shop documentation over more pages.