Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glacier mask for preserving totals when binning variables #1661

Merged
merged 3 commits into from Nov 9, 2023

Conversation

pat-schmitt
Copy link
Member

Here I add the use of the glacier mask for preserving totals when binning variables to the elevation bins. The consensus thickness is treated differently.

Closes #1660

  • Tests added/passed
  • Fully documented
  • Entry in whats-new.rst

@fmaussion
Copy link
Member

This bug was bad. It is unfortunate that the 1.6.1 folders have this issue...

@pat-schmitt
Copy link
Member Author

Yes, probably a good reason for a small 1.6.2 release soon...

@fmaussion fmaussion merged commit 365eef8 into OGGM:master Nov 9, 2023
20 of 26 checks passed
@fmaussion
Copy link
Member

I don't know yet how to document this issue. I think that it wouldn't be a problem for many users, but we don't know who is using these data.

@pat-schmitt pat-schmitt deleted the bug_elev_fl_binning branch November 21, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in preserving totals for binning variables in elevation band flowlines
2 participants