Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the COPDEM server to prism-dem-open.copernicus.eu #1684

Merged
merged 2 commits into from Apr 18, 2024

Conversation

dcodrut
Copy link
Contributor

@dcodrut dcodrut commented Feb 1, 2024

I replaced the server used for downloading the COPDEM30/90 (from ftps://cdsdata.copernicus.eu to https://prism-dem-open.copernicus.eu).

A few comments:

  • I replaced download_with_authentication with file_downloader because no credentials are needed anymore;

  • I kept the old parameter cppfile for _download_copdem_file_unlocked although it's not used anymore (didn't want to change too many things);

  • I updated the corresponding two tests from test_utils (i.e. test_copdem90a and test_copdem30). Please check them, I got a bit lost there.

  • Tests added/passed

  • Fully documented

  • Entry in whats-new.rst

@dcodrut dcodrut changed the title change the COPDEM server to prism-dem-open.copernicus.eu Change the COPDEM server to prism-dem-open.copernicus.eu Feb 1, 2024
@fmaussion
Copy link
Member

Thank you! Yes I'll check - bare with me though as this is a more consequential change than the code seems to indicate (we will have to check that the files are truly identical and mirror the server locally)

@pep8speaks
Copy link

Hello @dcodrut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1573:100: E501 line too long (127 > 99 characters)

@fmaussion
Copy link
Member

Thanks @dcodrut

This is now the "official" way to retrieve COPDEM data. It will imply that I redownload everything on cluster once more...

@fmaussion fmaussion merged commit cd4f53c into OGGM:master Apr 18, 2024
27 checks passed
@dcodrut
Copy link
Contributor Author

dcodrut commented Apr 19, 2024

Hey @fmaussion! Great to hear this.
Was just wondering, have you checked if the old DEMs and the new ones are exactly the same? I wanted to check this but I didn't have access to the previous server.

@fmaussion
Copy link
Member

Yes I checked one tile and its strictly the same. The filenames have changed though, and the product has a new timestamp (the update only seems to have added a few tiles...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants