Changes to the calving function #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 3, 2017 10:57
|
Great, thanks! Would you like feedback on this or can I merge right away? |
|
Well if you have time, It will be good..to double-check that the calving function and the "theoretical calving" is what we agreed when you were here. But I haven't changed any of that, so also you can just merge to master ... I only modified some things at the RGI_ID's that is now commented (new ID's to run) |
|
sorry it took me so long! I've looked at the function and it looks like what we agreed yes! But this doesn't mean it should be written in stone. Don't be afraid of improving it further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added the RGI'ID of the glaciers in the McNabb data base