Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further unification of log messages #278

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Further unification of log messages #278

merged 1 commit into from
Sep 8, 2017

Conversation

fmaussion
Copy link
Member

I try to remove all semicolons (:) because this is how I parse for error messages in the logs.

However my add-hoc solution isn't really good, because:

  • the parenthesis are bit ugly (the RGI id is given in parenthesis)
  • it would be MUCH better to have automatic logging / error tools on ourselves. We could easily make an OGGM specific Logger and Error subclasses instead.

@fmaussion fmaussion mentioned this pull request Sep 8, 2017
Open
@fmaussion fmaussion merged commit d7e8a60 into OGGM:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fmaussion