Small refactoring of tests #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, the code coverage doesn't check for tests code coverage anymore, which is actually a good thing. The bad thing is that this significantly reduced our overall test coverage score, but we simply have to admit that the truth is hard to accept ;-) We can work towards a higher coverage, but only at cost: a lot of the code can't easily be tested (graphics, workflow and downloads are the most poorly tested aspects of the code, while the model internals are very well tested!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly to reduce the running time of the test suite. It splits the model tests into two modules for dummy parallel processing on Travis and skips two tests which took much time without real benefits.