Add test for inversion with calving and new climate processing function #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @fmaussion! Thanks for updating the PR.
Comment last updated on November 24, 2018 at 17:00 Hours UTC |
fmaussion
changed the title
sumnonpuella
pushed a commit
to sumnonpuella/oggm
that referenced
this pull request
Jul 12, 2019
…on (OGGM#603) * WIP: add test for inversion with calving * Add docs * Small other modifs * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478
Closes #266
@bearecinos at first sight calving seems to work fine. Can you have a look at the test I wrote and compare with your code?
Another important thing: you should now be able to use the cfg defaults params for all things and remove the changes to "filter_*" options in your code.
And you also will have to deal with the multiple mus in your loops