Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for inversion with calving and new climate processing function #603

Merged
merged 5 commits into from Nov 24, 2018

Conversation

Projects
None yet
2 participants
@fmaussion
Copy link
Member

fmaussion commented Nov 22, 2018

Closes #478
Closes #266

  • Tests added/passed

@bearecinos at first sight calving seems to work fine. Can you have a look at the test I wrote and compare with your code?

Another important thing: you should now be able to use the cfg defaults params for all things and remove the changes to "filter_*" options in your code.

And you also will have to deal with the multiple mus in your loops

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Nov 22, 2018

Hello @fmaussion! Thanks for updating the PR.

Comment last updated on November 24, 2018 at 17:00 Hours UTC

@fmaussion fmaussion changed the title WIP: add test for inversion with calving Add test for inversion with calving and new climate processing function Nov 22, 2018

fmaussion added some commits Nov 22, 2018

@fmaussion fmaussion merged commit 5c660fa into OGGM:master Nov 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.7%) to 86.172%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.