Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variable for author name #109

Closed
rsletta opened this issue Apr 6, 2023 · 7 comments · Fixed by #291
Closed

Add variable for author name #109

rsletta opened this issue Apr 6, 2023 · 7 comments · Fixed by #291

Comments

@rsletta
Copy link

rsletta commented Apr 6, 2023

By adding a variable for author name, it will be able to use it for linking to a author document.
@hyleore
Copy link

hyleore commented Jul 15, 2023

I came here to request this - I like to have author's names linked to their quotes and ideas in Obsidian so that would be useful, if at all possible with how Kobo readers work.

@OGKevin
Copy link
Owner

OGKevin commented Jul 16, 2023

@rsletta i was under the impression that you wanted to pick this up? Is this still the case or shall I have a look?

@rsletta
Copy link
Author

rsletta commented Jul 16, 2023

It has been my intent. See my other comment.

@OGKevin
Copy link
Owner

OGKevin commented Jan 12, 2024

I had a look in the database, and it seems that it doesn't store who the author of a book is 😕
At least, in my database, the author table is empty.

Screenshot 2024-01-12 at 11 27 30
Screenshot 2024-01-12 at 11 27 32

So I'm a bit confused where the e-reader is pulling this information from to show in the UI 🤔

@rsletta
Copy link
Author

rsletta commented Jan 12, 2024 •
edited
Loading

The only data I found was in the content table. There is one entry where the author name is in the "attribution" column, which I assume is the ebook, based on MimeType.
image
The ContentID of that row is the same as the BookID of the other rows for that book.
image
image

OGKevin added a commit that referenced this issue Jan 20, 2024
@OGKevin
feat: include book details in export
c21d1af 
Closes: #109
@OGKevin OGKevin mentioned this issue Jan 20, 2024
Merged
@OGKevin
Copy link
Owner

OGKevin commented Jan 20, 2024

I've managed to even include more details than just the author!
Thanks for the hint.

OGKevin added a commit that referenced this issue Jan 27, 2024
@OGKevin
feat: include book details in export (#291)
abe5f8e 
* feat: include book details in export

Closes: #109

* fix: broken test
@OGKevin
Copy link
Owner

OGKevin commented Jan 27, 2024

If anyone is available or interested to test before an official release: https://github.com/OGKevin/obsidian-kobo-highlights-import/releases/tag/1.6.0-beta.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: include book details in export OGKevin/obsidian-kobo-highlights-import
3 participants
@rsletta @OGKevin @hyleore