Fix for Error when Exporting a Shape Key's Normals (#56) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes "Unknown Location -1" Error when Exporting a Shape Key's Normals and/or Animations #56
Created a mapping between tesselated faces and polygon faces, before the untesselated mesh was being indexed by tesselated indexes
Normals were being stored as a delta from original normal to shape normal,
PlayPenTests.cppshows that is not how it should be done.Tested with all Blender basic meshes and different shape keys: Cube / Plane / Triangle / Icosphere / Sphere / Cylinder
Tested in Ogre with a geometry shader that shows Normals, that the normals are being correctly deformed by the Shape Keys
Tested with MBetters model (still won't work for him due to OgreMeshTool Fails #78, which is a Ogre 2.x bug)
Custom Normals were not being taken into account
(Progress Bug) Fix: Avoid division by zero for meshes with only one triangle
(README) Fix: "Exporting Skeletal Animations" was not in the index
There is still work to do, becase the fix in this case is actually a patch on a bad design.
The proper way to export the Shape Keys would be to apply only the Shape Key to export, create a copy mesh, tesselate it and then export that.
(Crossing fingers that the vertex indexes will be the same as the tesselated mesh without the shape key applied, I don't know if the algorithm is consistent so this approach might fail)
Anyway, the current fix is good enough (for now).