This repository has been archived by the owner on Aug 7, 2020. It is now read-only.
Fix for normal vertices #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplied it to the normal vertices, instead of the matrix aiM
paroj
suggested changes
Sep 25, 2018
src/AssimpLoader.cpp
Outdated
| aiQuaternion rotation; | ||
| aiVector3D position; | ||
| aiVector3D scaling; | ||
| aiM.Decompose(scaling, rotation, position); |
There was a problem hiding this comment.
i think just copying aiM and setting its translation to 0 should be enough
|
👍 thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a transformation matrix without a translation component and applied it to the normal vertices, instead of the matrix aiM