[Metal] Do not crash if a shader failed when reflection (#251)

Log it and mark it as "compile error" instead
Fixes #251

RenderSystems/Metal/src/OgreMetalProgram.mm

@@ -319,6 +319,8 @@ of this software and associated documentation files (the "Software"), to deal
             if( error )
                 errorDesc = [error localizedDescription].UTF8String;
 
+            mCompileError = true;
+
             OGRE_EXCEPT( Exception::ERR_RENDERINGAPI_ERROR,
                          "Failed to create pipeline state for reflection, error " +
                          errorDesc, "MetalProgram::analyzeComputeParameters" );
@@ -394,6 +396,8 @@ of this software and associated documentation files (the "Software"), to deal
             if( error )
                 errorDesc = [error localizedDescription].UTF8String;
 
+            mCompileError = true;
+
             OGRE_EXCEPT( Exception::ERR_RENDERINGAPI_ERROR,
                          "Failed to create pipeline state for reflection, error " +
                          errorDesc, "MetalProgram::analyzeRenderParameters" );
@@ -608,15 +612,22 @@ of this software and associated documentation files (the "Software"), to deal
         if( !mLibrary )
             return;
 
-        if( mType != GPT_COMPUTE_PROGRAM )
+        try
         {
-            //You think this is a code smell? How about making BUILDconstantDefinitions const???
-            //It's an oxymoron.
-            const_cast<MetalProgram*>(this)->analyzeRenderParameters();
+            if( mType != GPT_COMPUTE_PROGRAM )
+            {
+                //You think this is a code smell? How about making BUILDconstantDefinitions const???
+                //It's an oxymoron.
+                const_cast<MetalProgram*>(this)->analyzeRenderParameters();
+            }
+            else
+            {
+                const_cast<MetalProgram*>(this)->analyzeComputeParameters();
+            }
         }
-        else
+        catch( RenderingAPIException &e )
         {
-            const_cast<MetalProgram*>(this)->analyzeComputeParameters();
+            LogManager::getSingleton().logMessage( e.getFullDescription() );
         }
     }
     //-----------------------------------------------------------------------