Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc:modify README.md #82

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Conversation

Rae-Lee
Copy link

@Rae-Lee Rae-Lee commented Aug 20, 2022

No description provided.

Copy link

@tai271828 tai271828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking comments for @Rae-Lee 's reference. I think it is acceptable at such early stage of development.

Thank @Rae-Lee for your contribution!

### Pre-requisite

- Download nvm
go to https://github.com/nvm-sh/nvm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "G"o (capital G)

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
```
if you are using windows
go to https://github.com/coreybutler/nvm-windows and download .zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto. "If" and "Go".

if you are using windows
go to https://github.com/coreybutler/nvm-windows and download .zip

- Download node(version 14 and 16 is not allowed)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: space is required between node and bracket (.

```
App running at:
- Local: http://localhost:8080/
- Network: http://192.168.50.226:8080/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IP varies depending on your working environment. We may want to elaborate explicitly.

@tai271828 tai271828 merged commit a5d4d0e into OH-SHOWN:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants