-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osl_maxfilter doesn't work with --trans default #192
Comments
Should also include some documentation on the fact that this should be run separate to sss |
Does simply changing https://github.com/OHBA-analysis/osl/blob/main/osl/maxfilter/maxfilter.py#L453 to
resolve this? |
The above change will let you use |
I think your changes fixed part of it, but I don't think it enables you to specify a particular origin. Namely, the origin has three flags, where only 1 is supported. I do wonder whether this is already (partly) implemented by |
The documentation of the
osl_maxfilter
notes we can useosl_maxfilter input_files.txt /path/to/my/output/dir/ --trans default --origin 0 0 40 --frame head --force
to align head position between recordings by aligning them to a pre-specified position.
However, these options are currently not supported.
Having 4 flags is currently also not possible, so @AJQuinn suggestion was to create a new option that refers to
default --origin 0 0 40 --frame head --force
The text was updated successfully, but these errors were encountered: