TravisCI testing

[vojtechhuser]

In 2016, all changes were tested using TravisCI mechanism.
But it required a lot of legwork.

What is the new routine for approving PRs? (review by one coder) and merge (with testing by users)?

[t-abdul-basser]

I assume that it is same as before. @chrisknoll please confirm.

• Submitter should make changes in feature branch on their own forked repo.
• Submitter create PR target Achilles:master
• at least one reviews
• LD creates local repo branch and re-issue PR to target local repo branch.
• LD squashes and merges in local branch
• LD mergex into master pre-release to kick off travisCI

[chrisknoll]

That's all correct, except you don't need to re-issue the PR to a local branch, you can edit an existing PR and target a new branch. Of course, a new branch must be created to do this, and you can do this via the github repo homescreen:

On the branch select dropdown, you have the option to type in a brand new branch name, this will create a new branch off master. Then you can edit the PR to target this new branch. So, step 4 above, chagnes from 'LD creates local repo branch and re-issue PR' to: 'LD creates a branch in github, and edits the PR to merge into the new branch'. Then the Pr is merged into the new branch (as step 5 above), Travis will run tests, and then finally new PR created to merge into master.

[anthonysena]

Hi - just catching up a bit here. It looks like there were some Oracle specific problems with #211 that need to be addressed. If I understand the procedure, we'll aim to put in a PR with those fixes and target the pr-211 branch in this repository for testing. Let me know if I'm mistaken in this approach. Thanks!

[vojtechhuser]

pershaps we should 1.remove the "as" and combine both related PRs into one testing session.

[chrisknoll]

@anthonysena , local branches will work fine with the Travis CI. The steps that @t-abdul-basser calls out are for cases where PRs come from external forks (the TravisCI doesn't run on external forks because the external fork might do something nefarious like echo out the database credentails. Only local branches are considered 'trusted').