Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DQD v2.0 #199

Closed
clairblacketer opened this issue Nov 7, 2022 · 4 comments
Closed

Support for DQD v2.0 #199

clairblacketer opened this issue Nov 7, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@clairblacketer
Copy link
Collaborator

Describe the solution you'd like
I would like to ensure that the JSON file produced by DQD v2.0 is supported by ARES

We made some changes to the DQD in v2.0 and I am not sure if those changes will break anything when ARES tries to render the JSON. We have already seen some issues at Janssen with this but we are not entirely sure of the problem.

@fdefalco
Copy link
Contributor

fdefalco commented Nov 9, 2022

Sample DQD V2 file
dq-result.zip

@ssamus ssamus added this to Needs triage in backlog triage via automation Nov 10, 2022
@ssamus ssamus added the enhancement New feature or request label Nov 10, 2022
@Mikhail-iontsev
Copy link
Collaborator

I haven't found any breaking changes in the DQD v2 generated file. There are 1-2 properties missing, a few additional ones, but the ones missing do not seem to be used by Ares.

Haven't seen any issues on my side using the v2 file. Could you please describe the issues you encountered?

@fdefalco
Copy link
Contributor

One issue I've seen is in the execution of AresIndexer::buildDataQualityIndex

Error in [.data.frame(results, results[, "FAILED"] == 1, c("CHECK_NAME", :
undefined columns selected

I think this is associated with the change of the types of status that can exist in DQD v2. Also going forward with DQD v2 results we'll want to add summaries for failes, passed, is_error, and not_applicable to AresIndexer as well as the reports in Ares.

@fdefalco
Copy link
Contributor

Related to this potential fix:
OHDSI/AresIndexer@main...ganisimov:AresIndexer:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants