Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizing window causes unconstrained chart size #1105

Closed
fdefalco opened this issue Nov 12, 2018 · 5 comments · Fixed by OHDSI/Visualizations#38 or #1187
Closed

resizing window causes unconstrained chart size #1105

fdefalco opened this issue Nov 12, 2018 · 5 comments · Fixed by OHDSI/Visualizations#38 or #1187

Comments

@fdefalco
Copy link
Contributor

Expected behavior

Charts should have a maximum size

Actual behavior

Charts grow unrestricted

Steps to reproduce behavior

Resize the window to narrow width and then expand, repeat.

image

@fdefalco fdefalco added this to the V2.7.0. "Bug free" milestone Nov 12, 2018
@fdefalco fdefalco self-assigned this Nov 12, 2018
@fdefalco fdefalco added the bug label Nov 12, 2018
@fdefalco
Copy link
Contributor Author

underlying charting library doesn't provide adequate options for height control. suggest re-evaluate use of vega for a atlas 3.0 release.

@chrisknoll
Copy link
Collaborator

What happens when you specify a max-height on the containing element?

@fdefalco
Copy link
Contributor Author

The panel conforms to the style while the chart does not.

image

@chrisknoll
Copy link
Collaborator

@wivern , @pavgra , Could you assist with this? I'm unsure if it is something related to the flex-box layout or something else.

@pavgra
Copy link
Contributor

pavgra commented Nov 27, 2018

@fdefalco , I don't think that we should introduce new libs before 3.0, but we definitely need to fix things. I'll re-open the issue and out team will try to figure out smth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants