Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with new SQL scripts in JCDMBuilder #160

Closed
bmosseveld opened this issue Feb 8, 2018 · 2 comments
Closed

Issues with new SQL scripts in JCDMBuilder #160

bmosseveld opened this issue Feb 8, 2018 · 2 comments
Assignees

Comments

@bmosseveld
Copy link

The JCDMBuilder can't deal with the semicolon on the end of line 5 of the license header. They break the comment block and therefore should be removed.
Most of the CREATE TABLE definitions have the opening parenthesis on the next line. This causes the original JCDMBuilder to not perform the DROP TABLE commands for those tables. I made a work-around for that in our own version of JCDMBuilder.

@clairblacketer clairblacketer self-assigned this Feb 13, 2018
@clairblacketer
Copy link
Contributor

@bmosseveld is this still a problem?

@bmosseveld
Copy link
Author

Semicolon: In the JCDMBuilder I now just ignore the lines starting with a # sign.

Drop tables: It no longer relies on the ddl script to drop the tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
CDM v5.3 Bugfixes
  
Awaiting triage
Development

No branches or pull requests

2 participants