Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released version currently failing unit tests #540

Open
schuemie opened this issue May 9, 2024 · 1 comment
Open

Released version currently failing unit tests #540

schuemie opened this issue May 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@schuemie
Copy link
Member

schuemie commented May 9, 2024

This seems to be a bit silly, but I think the issue is that, with R 4.4.0, this line needs quotes around the 0, so:

is_installed <- function(pkg, version = "0") {

(There is also a note about a mismatch in documentation in the R Check results you may want to fix)

@katy-sadowski
Copy link
Collaborator

Thanks for figuring that out! I was pretty confused why this randomly started showing up. The docs note too must be a new thing in R Check. One of the params in the header isn't capitalized the right way. I'll fix both of these in the next release :)

@katy-sadowski katy-sadowski added the bug Something isn't working label May 9, 2024
@katy-sadowski katy-sadowski self-assigned this May 9, 2024
@katy-sadowski katy-sadowski added this to TODO in Version 2.X May 9, 2024
@katy-sadowski katy-sadowski moved this from TODO to In Progress in Version 2.X May 21, 2024
@katy-sadowski katy-sadowski moved this from In Progress to Done in Version 2.X May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants