You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function for downloading drivers downloadJdbcDrivers has an argument method which is then passed to utils::download.file per the documentation here:
#' @param method The method used for downloading files. See \code{?download.file} for details and options.
Looking at the documentation for utils::download.file, the method argument will assume a default value of auto but it can be overridden using options(download.file.method = "auto").
So I'd propose we remove the method argument since it prevents users from controlling the behavior of utils::download.file using options and instead we can just note this in the description of the function or link to the utils documentaiton.
The text was updated successfully, but these errors were encountered:
anthonysena
changed the title
Download drivers method
Download drivers method argument
Oct 16, 2022
The function for downloading drivers
downloadJdbcDrivers
has an argumentmethod
which is then passed toutils::download.file
per the documentation here:DatabaseConnector/R/Drivers.R
Line 36 in 6bdece8
Looking at the documentation for utils::download.file, the
method
argument will assume a default value ofauto
but it can be overridden usingoptions(download.file.method = "auto")
.So I'd propose we remove the
method
argument since it prevents users from controlling the behavior ofutils::download.file
usingoptions
and instead we can just note this in the description of the function or link to the utils documentaiton.The text was updated successfully, but these errors were encountered: