Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download drivers method argument #206

Open
anthonysena opened this issue Oct 16, 2022 · 0 comments
Open

Download drivers method argument #206

anthonysena opened this issue Oct 16, 2022 · 0 comments
Labels
enhancement New functionality that could be added

Comments

@anthonysena
Copy link
Contributor

The function for downloading drivers downloadJdbcDrivers has an argument method which is then passed to utils::download.file per the documentation here:

#' @param method The method used for downloading files. See \code{?download.file} for details and options.

Looking at the documentation for utils::download.file, the method argument will assume a default value of auto but it can be overridden using options(download.file.method = "auto").

So I'd propose we remove the method argument since it prevents users from controlling the behavior of utils::download.file using options and instead we can just note this in the description of the function or link to the utils documentaiton.

@anthonysena anthonysena changed the title Download drivers method Download drivers method argument Oct 16, 2022
@schuemie schuemie added the enhancement New functionality that could be added label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality that could be added
Projects
None yet
Development

No branches or pull requests

2 participants