You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the unit tests use a permanent table called cohorts_of_interest (see here and here, with SQL here). This means that if multiple processes try to create this table simultaneously there could be collisions. In fact, because the unit tests take over 2 hours to complete, it is not unlikely that this will happen!
A solution could be to use a temp table instead. This would require that the connection be kept alive across the various tests (or else the temp table is automatically dropped). Also remember that the temp tables need to be explicitly deleted after finishing the tests, for platforms where we merely emulate temp tables (like Oracle, Spark, and BigQuery)
The text was updated successfully, but these errors were encountered:
to a temp table that either uses a dynamic name that is unique per session (so different OS unit tests do not collide) or add a suffix to the temp table name per OS. Modify all other dependent code to use the temp table and clean up when the test is complete so they are not lingering on platforms such as Oracle.
Next steps
There is likely a way to condense the unit tests for FE such that we can load the target RDBMS and use it throughout the test execution so that we don't have duplicate unit tests for each RDBMS platforms. Tagging @azimov as I think he's done this for CohortDiagnostics.
Currently the unit tests use a permanent table called
cohorts_of_interest
(see here and here, with SQL here). This means that if multiple processes try to create this table simultaneously there could be collisions. In fact, because the unit tests take over 2 hours to complete, it is not unlikely that this will happen!A solution could be to use a temp table instead. This would require that the connection be kept alive across the various tests (or else the temp table is automatically dropped). Also remember that the temp tables need to be explicitly deleted after finishing the tests, for platforms where we merely emulate temp tables (like Oracle, Spark, and BigQuery)
The text was updated successfully, but these errors were encountered: