Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly R-check fails #239

Closed
ginberg opened this issue Mar 25, 2024 · 3 comments · Fixed by #240
Closed

Weekly R-check fails #239

ginberg opened this issue Mar 25, 2024 · 3 comments · Fixed by #240
Assignees
Milestone

Comments

@ginberg
Copy link
Collaborator

ginberg commented Mar 25, 2024

I noticed the weekly R check is failing, see error below. There haven't been any code changes, it might be because a newer version of a library is used.

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-spot-checks.R:201:3'): Run spot-checks at per-person level on Oracle ──
  <purrr_error_indexed/rlang_error/error/condition>
  Error in `purrr::map(op$joins$table, ~sql_optimise(sql_build(.x, con, sql_options = sql_options), 
      con))`: ℹ In index: 1.
  Caused by error in `rlang::sym()`:
  ! No known SQL translation
  
  [ FAIL 1 | WARN 4 | SKIP 85 | PASS 72 ]
  Error: Test failures
  Execution halted
Running the tests in ‘tests/testPostgres.R’ failed.
Last 13 lines of output:
   13.               └─tidyselect:::walk_data_tree(new, data_mask, context_mask)
   14.                 └─tidyselect:::expr_kind(expr, context_mask, error_call)
   15.                   └─tidyselect:::call_kind(expr, context_mask, error_call)
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-spot-checks.R:187:3'): Run spot-checks at per-person level on PostgreSQL ──
  <purrr_error_indexed/rlang_error/error/condition>
  Error in `purrr::map(op$joins$table, ~sql_optimise(sql_build(.x, con, sql_options = sql_options), 
      con))`: ℹ In index: 1.
  Caused by error in `rlang::sym()`:
  ! No known SQL translation
  
  [ FAIL 1 | WARN 3 | SKIP 85 | PASS 72 ]
  Error: Test failures
  Execution halted
Running the tests in ‘tests/testSqlite.R’ failed.
Last 13 lines of output:
   30. │ └─dbplyr:::escape_infix_expr(enexpr(x), x)
   31. └─rlang::sym
   32.   └─cli::cli_abort(...)
   33.     └─rlang::abort(...)
  ── Error ('test-spot-checks.R:213:3'): Run spot-checks at per-person level on Eunomia ──
  <purrr_error_indexed/rlang_error/error/condition>
  Error in `purrr::map(op$joins$table, ~sql_optimise(sql_build(.x, con, sql_options = sql_options), 
      con))`: ℹ In index: 1.
  Caused by error in `rlang::sym()`:
  ! No known SQL translation
  
  [ FAIL 3 | WARN 5 | SKIP 57 | PASS 141 ]
  Error: Test failures
  Executing SQL took 0.00473 secs
  Execution halted
Running the tests in ‘tests/testSqlServer.R’ failed.
Last 13 lines of output:
   13.               └─tidyselect:::walk_data_tree(new, data_mask, context_mask)
   14.                 └─tidyselect:::expr_kind(expr, context_mask, error_call)
   15.                   └─tidyselect:::call_kind(expr, context_mask, error_call)
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-spot-checks.R:194:3'): Run spot-checks at per-person level on SQL Server ──
  <purrr_error_indexed/rlang_error/error/condition>
  Error in `purrr::map(op$joins$table, ~sql_optimise(sql_build(.x, con, sql_options = sql_options), 
      con))`: ℹ In index: 1.
  Caused by error in `rlang::sym()`:
  ! No known SQL translation
@ginberg
Copy link
Collaborator Author

ginberg commented Mar 25, 2024

it seems to be related to a version update of dbplyr, see

@ginberg ginberg mentioned this issue Mar 25, 2024
@ginberg ginberg added this to the V3.5.0 milestone Mar 25, 2024
@schuemie
Copy link
Member

@ginberg : Thanks for fixing this! I'm preparing the 2024Q1 HADES-wide release, which should be ready by the end of this month (so just a couple of more days). I currently am failing unit tests because of this FeatureExtraction issue.

Would it be possible to create a patch release of FeatureExtraction (or any release) that fixes this issue today or tomorrow?

@ginberg
Copy link
Collaborator Author

ginberg commented Mar 28, 2024

@schuemie sure we can make a patch release, I will work on that today or latest by tomorrow

@ginberg ginberg modified the milestones: V3.5.0, V3.4.1 Mar 28, 2024
@ginberg ginberg self-assigned this Mar 28, 2024
@ginberg ginberg closed this as completed Mar 28, 2024
@ginberg ginberg linked a pull request Mar 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants