Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensively fix missing leading zeros in the concept_codes for NAACCR values. #234

Closed
mgurley opened this issue Dec 20, 2019 · 1 comment

Comments

@mgurley
Copy link
Collaborator

mgurley commented Dec 20, 2019

There is still a consistent problem of missing leading zeros in the concept_code column of NAACCR values:

For example, compare
http://datadictionary.naaccr.org/default.aspx?c=10#1504
https://api.seer.cancer.gov/rest/naaccr/latest/item/1504
http://athena.ohdsi.org/search-terms/terms/35918869

http://datadictionary.naaccr.org/default.aspx?c=10#1506
https://api.seer.cancer.gov/rest/naaccr/latest/item/1506
http://athena.ohdsi.org/search-terms/terms/35918276

This issue was partially addressed in #60, but it seems that there are still problems. Can we do a systematic re-pull of the NAACCR data dictionary via the SEER API to fix this problem accross the board?

@sratwani
Copy link
Collaborator

@mgurley Looks like this issue has been fixed. I checked the above examples and the NAACCR Data Dictionary and Athena seem to be in sync. Can you confirm please.

@sratwani sratwani moved this from In progress to Backlog in Oncology WG Dec 9, 2021
@mgurley mgurley closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Oncology WG
  
Backlog
Development

No branches or pull requests

2 participants