Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released version currently failing unit tests #406

Closed
schuemie opened this issue Aug 11, 2023 · 1 comment · Fixed by #410
Closed

Released version currently failing unit tests #406

schuemie opened this issue Aug 11, 2023 · 1 comment · Fixed by #410
Assignees
Labels

Comments

@schuemie
Copy link
Member

https://github.com/OHDSI/PatientLevelPrediction/actions/runs/5770541557/job/15643680529

I see:

  Running ‘testthat.R’ [13m/15m]
 [13m/15m] ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
   10.       │   └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
   11.       │     └─base (local) doTryCatch(return(expr), name, parentenv, handler)
   12.       └─PatientLevelPrediction::evaluatePlp(...)
   13.         └─PatientLevelPrediction:::getEvaluationStatistics(...)
   14.           ├─base::do.call(...)
   15.           └─PatientLevelPrediction:::getEvaluationStatistics_binary(...)
   16.             └─PatientLevelPrediction::calibrationLine(...)
  
  ══ Failed tests ════════════════════════════════════════════════════════════════
  Error in if (is.null(x[["trace"]]) || trace_length(x[["trace"]]) == 0L) { : 
    missing value where TRUE/FALSE needed
  Calls: test_check ... vapply -> FUN -> paste0 -> format -> format.expectation
  In addition: Warning message:
  call dbDisconnect() when finished working with a connection 
  Execution halted
@egillax
Copy link
Collaborator

egillax commented Aug 22, 2023

This failed again over the weekend but with a better error message:

https://github.com/OHDSI/PatientLevelPrediction/actions/runs/5911247612/job/16033602072

I think this is because newest version of reticulate changed how indexing works on python objects:

New [ and [<- methods that invoke Python getitem, setitem and delitem. The R generics [ and [<- now accept python-style slice syntax like x[1:2:3]. See examples in ?py_get_item.

I'll fix it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants