Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Sources only pulls sources with CDM daimon #720

Closed
alondhe opened this issue Dec 5, 2018 · 3 comments
Closed

Data Sources only pulls sources with CDM daimon #720

alondhe opened this issue Dec 5, 2018 · 3 comments
Assignees
Labels

Comments

@alondhe
Copy link
Contributor

alondhe commented Dec 5, 2018

@chrisknoll and @anthonysena -- I tried removing the JNJ_NETWORK CDM source daimon to prevent it from appearing as a source that cohorts can be generated against. One issue: in Data Sources, JNJ_NETWORK is no longer an option, I suppose it's only grabbing sources that have the CDM daimon.

@anthonysena anthonysena added this to the V2.7.0. "Bug free" milestone Jan 16, 2019
@marpozh
Copy link
Contributor

marpozh commented Jan 18, 2019

@alondhe - hi, are you sure it is consistent to show reports (in Data Sources tab) if the data source doesn't have a CDM daimon?
If there is no cdm data - it seems that we should not show reports on this data.

@chrisknoll
Copy link
Collaborator

I think the requirement on the datasources reports is that we need to resolve concept IDs to names, so we probably simply required the CDM daimon to exist in order to view those reports. Instead, maybe we need to require a vocabulary + results daimon to exist on a source for it to appear in datasources?

@marpozh
Copy link
Contributor

marpozh commented Jan 18, 2019

@chrisknoll - ok, let's do if this way. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants