remove results tables from ohdsi database flyway configuration

[fdefalco]

No description provided.

[leeevans]

This change would break the following useful configuration:

single CDM database (no results tables)
single OHDSI database (with results tables created by flyway)

source daimon table includes a results entry with table qualifier entry of OHDSI.dbo

This is a simple configuration that works well for sites that only have a single CDM and doesn't require the results tables to be manually created in that single CDM database, It also allows the standard SQLServer dbo database schema to be used for all tables in both databases. Since there is only a single CDM database all the results can be kept in the OHDSI database results tables.

[chrisknoll]

@leeevans is correct. Should this issue be closed?

[fdefalco]

It is a happy coincidence that the configuration Lee mentions works as it does. it doesn't solve the broader issue that we currently have no way of properly configuring result schemas, especially in the case of a site with multiple CDMs. As I understand it there are a variety of reasons for the current limitations. The first is that Flyway doesn't support APS and so our result table environments are configured manually. I have just completed a fork of Flyway that adds support for APS that still requires testing but my intention is that we change our approach from manual to Flyway configuration with the newly added support.

The second limitation is in the way we use configuration files to tell Flyway what database to configure. While this works for the OHDSI repository database it doesn't allow Flyway to configure multiple databases. I have recently completed a branch of WebAPI that will configure all result daimon databases on demand using a separate resource location for migrations.

With these two new features we should be able to improve our configuration/installation process and still support the scenarios Lee described, but by design.

[anthonysena]

Closing this due to the age of this issue and to also note that deploying the results schema to a CDM should follow this documented process: https://github.com/OHDSI/WebAPI/wiki/CDM-Configuration#results-schema-setup