Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not functioning context menu on Cornerstone tools #1406

Closed
vicOnGit75 opened this issue Jan 31, 2020 · 4 comments
Closed

Not functioning context menu on Cornerstone tools #1406

vicOnGit75 opened this issue Jan 31, 2020 · 4 comments
Labels
Bug Verified Bug reported, reproducible, and verified.

Comments

@vicOnGit75
Copy link
Contributor

Right Click on a drawn tool causes popup of system context menu that either cover tool context menu or displayed side by side with it:

  • Select any procedure
  • select any image
    -select tool type a and draw a tool ( any type e.g. angle)
  • Right click
    -See behavior described above.
    Reproduced on https://viewer-dev.ohif.org/

Untitled

@dannyrb dannyrb added Bug Verified Bug reported, reproducible, and verified. and removed Awaiting Reproduction labels Jan 31, 2020
@dannyrb
Copy link
Member

dannyrb commented Jan 31, 2020

@vicOnGit75, I also experience this issue when using FireFox. Other core team members have reported that they are unable to reproduce on their machine. This is likely something as simple as preventing the contextmenu event from bubbling when interacting with canvases/viewports.

@vicOnGit75
Copy link
Contributor Author

@dannyrb ,
I experienced it on my working environment ( Win10,Chrome) after building version from the end of December, positively not having this problem with version from end of October ( sorry for missing exact labels).
Regarding the fix- looks like this,
but changing
element.addEventListener(csTools.EVENTS.MOUSE_CLICK, handleClick,false); in elementEnabledHandler(evt)
and
adding
event.preventDefault();
event.stopPropagation();
in OnRightClick ( both in AppExtension/init.js)
didn't help.

@arthur-miller
Copy link
Contributor

@dannyrb, we can close this now, right?

@dannyrb
Copy link
Member

dannyrb commented Mar 10, 2020

Appreciate the call-out. Thanks, @arthur-miller. @vicOnGit75, if you have issues with latest, please don't hesitate to report back.

@dannyrb dannyrb closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Verified Bug reported, reproducible, and verified.
Projects
None yet
Development

No branches or pull requests

3 participants