Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurements for cornerstone tools #1714

Closed
akshaya999 opened this issue May 6, 2020 · 0 comments · Fixed by #2038
Closed

Measurements for cornerstone tools #1714

akshaya999 opened this issue May 6, 2020 · 0 comments · Fixed by #2038

Comments

@akshaya999
Copy link

Hi,

I was able to add a cornerstone tools to the OHIF viewer, but I noticed that the tool's measurements weren't getting mapped in the measurement menu on the right side. I was wondering what I would have to do order for the cornerstone segmentations tools measurements to show up in the measurements menu.

Thanks
slak44 pushed a commit to Medicai-io/OHIF that referenced this issue Sep 10, 2020
fix: use SeriesMetadata method instead of property
9d8cdbb 
fixes OHIF#1714

Call getInstanceCount() instead of manually checking length (which does not work)
@slak44 slak44 mentioned this issue Sep 11, 2020
Merged
5 tasks
swederik pushed a commit that referenced this issue Sep 30, 2020
@slak44
fix: use SeriesMetadata method instead of property in findMostRecentS…
91364db 
…tructuredReport (#2038)

fixes #1714

Call getInstanceCount() instead of manually checking length (which does not work)

Co-authored-by: Stefan Silviu <silviu.stefan@ab4.systems>
pieper pushed a commit to ImagingDataCommons/Viewers that referenced this issue Oct 7, 2020
@JamesAPetts @swederik
@ohif-bot @Alex979 @dannyrb @ladeirarodolfo @WoonchanCho @chipswithvinegar @nbyl @slak44
Idc update (#8)
75b5d9d 
* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool (OHIF#1984)

* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool

* Fix import of react-vtkjs-viewport to cornerstone-tools path.

* Increase maximum load time of MPR test now we are throttling requests.

* Remove debugger

Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.0
 - @ohif/extension-dicom-rt@0.4.0
 - @ohif/extension-dicom-segmentation@0.4.0
 - @ohif/extension-vtk@1.7.0
 - @ohif/core@2.10.0
 - @ohif/viewer@4.4.0

* fix: Avoid lerna:restore unless we are on Netlify (closes OHIF#1926, OHIF#1996)

* wip

* fix: Fix incorrect command name in Percy test (OHIF#1999)

* perf(stackPrefetch): Added stackPrefetch config with 20 max concurrent requests (OHIF#2000)

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.1
 - @ohif/viewer@4.4.1

* feat: 🎸 Filter/promote multiple series instances (OHIF#1533)

improve filter/promote to be applied on multiple series instances

✅ Closes: 1532

Co-authored-by: Rodolfo Ladeira <rodolfo_radical@hotmail.com>

* chore(release): publish [skip ci]

 - @ohif/viewer@4.5.0

* fix: Updated react-cornerstone-viewport to version 4.0.2 (OHIF#2001)

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.2
 - @ohif/viewer@4.5.1

* fix: 🐛 Fail gracefully on an MPR load error (OHIF#1992)

* feat: 🎸 Update react-vtkjs-viewport usage to use requestPool

* Fix import of react-vtkjs-viewport to cornerstone-tools path.

* Increase maximum load time of MPR test now we are throttling requests.

* fix: 🐛 Fail gracefully on an MPR load error

* Respond to reviewer comments.

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.7.1
 - @ohif/viewer@4.5.2

* [IDC-1994] Sort series list by SeriesNumber, and sort by same SeriesNumber by date/time. (OHIF#2010)

* Sort based on SeriesNumber and SeriesDate/SeriesTime.

* Harden, and perform final sort in algorithm if last N entries have the same SeriesNumber.

* Switch to insertion rather than sorting as sorting is too slow. Reimplement low priority sorting into new insertion method.

* Fix local file viewing.

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.2.5
 - @ohif/extension-dicom-microscopy@0.51.1
 - @ohif/extension-dicom-pdf@1.0.4
 - @ohif/extension-dicom-rt@0.4.1
 - @ohif/extension-dicom-segmentation@0.4.1
 - @ohif/extension-vtk@1.7.2
 - @ohif/core@2.10.1
 - @ohif/viewer@4.5.3

* [IDC-2017] Harden segmentation import to support more SEGs (OHIF#2024)

* fix: 🐛 Upgrade dcmjs version to support more SEGs

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.3
 - @ohif/extension-dicom-html@1.2.6
 - @ohif/extension-dicom-rt@0.4.2
 - @ohif/extension-dicom-segmentation@0.4.2
 - @ohif/extension-vtk@1.7.3
 - @ohif/core@2.10.2
 - @ohif/viewer@4.5.4

* [IDC-1939] Debug Dialog part 1 (OHIF#2011)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.4
 - @ohif/extension-debugging@0.1.3
 - @ohif/extension-dicom-html@1.2.7
 - @ohif/extension-dicom-microscopy@0.51.2
 - @ohif/extension-dicom-pdf@1.0.5
 - @ohif/extension-dicom-rt@0.4.3
 - @ohif/extension-dicom-segmentation@0.4.3
 - @ohif/extension-lesion-tracker@0.2.1
 - @ohif/extension-vtk@1.7.4
 - @ohif/core@2.10.3
 - @ohif/viewer@4.5.5

* IDC-1532 multiple series search google (OHIF#2026)

* Multiple series search for google cloud adapter.

* Revert IDC config.

* fix: 🐛 Series filtering on multiple series for google

* Revert changes to default config.

* Address reviewers comments.

* Fixed spelling mistakes

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.7.5
 - @ohif/core@2.10.4
 - @ohif/viewer@4.5.6

* Split query parameter calls. (OHIF#2035)

* chore(release): publish [skip ci]

 - @ohif/viewer@4.5.7

* [IDC-1672] Highlight SEG segment/ RT structure when click to jump. (OHIF#2034)

* Highlight for RTSTRUCT.

* SEG temp crosshairs.

* Disable RT highlighting for now.

* Remove TODO

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.1.4
 - @ohif/extension-dicom-rt@0.4.4
 - @ohif/extension-dicom-segmentation@0.4.4
 - @ohif/viewer@4.5.8

* [IDC-1129] - DICOM Tag Viewer extension (OHIF#2022)

* WIP render top level tags.

* Add drop down to select series.

* Fix errors with type 2 sequences.

* WIP swap instance.

* Fix formatting and make fullscreen.

* Remove debuggers.

* Finish formatting.

* Fix error with double SeriesNumber deconstruction.

* Address reviewer comments.

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-html@1.2.8
 - @ohif/extension-dicom-microscopy@0.51.3
 - @ohif/extension-dicom-pdf@1.0.6
 - @ohif/extension-dicom-rt@0.4.5
 - @ohif/extension-dicom-segmentation@0.4.5
 - @ohif/extension-dicom-tag-browser@0.0.2
 - @ohif/extension-vtk@1.7.6
 - @ohif/core@2.10.5
 - @ohif/ui@1.5.4
 - @ohif/viewer@4.5.9

* [IDC-2006] - optional mailTo for debugging extension. (OHIF#2027)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* WIP

* WIP

* Finish mailTo

* chore(release): publish [skip ci]

 - @ohif/extension-debugging@0.1.5
 - @ohif/extension-vtk@1.7.7
 - @ohif/ui@1.5.5
 - @ohif/viewer@4.5.10

* [IDC-1905] Hover tooltips for Segmentation + RTSTRUCT extension (OHIF#2044)

* WIP debug dialog

* Rename the p10 downloader extension to debugger extension, add button to toolbar. Deactivate it by default.

* Fix unit tests

* WIP

* WIP

* Finish mailTo

* tooltop

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-rt@0.4.6
 - @ohif/extension-dicom-segmentation@0.4.6
 - @ohif/viewer@4.5.11

* [IDC-2049] Sort Tags in Tag browser split items in sequences, add indent after space. (OHIF#2053)

* Sort tag browser, add items, add indent.

* Remove debugger.

* chore(release): publish [skip ci]

 - @ohif/extension-dicom-tag-browser@0.0.3
 - @ohif/viewer@4.5.12

* Update react-cornerstone-viewport for performance improvements (OHIF#2062)

* Update react-cornerstone-viewport

* Bump react-cornerstone-viewport version.

* Comment out tests which always cause problems.

* chore(release): publish [skip ci]

 - @ohif/extension-cornerstone@2.9.5
 - @ohif/viewer@4.5.13

* [IDC-2052] PWA start url (OHIF#2070)

Change start_url in manifest.json from "./index.html" to "./"

Co-authored-by: Woonchan Cho <wcho24@wustl.edu>

* chore(release): publish [skip ci]

 - @ohif/viewer@4.5.14

* fix: Enable port changes for Docker image using the PORT variable (OHIF#2016)

* fix: use SeriesMetadata method instead of property in findMostRecentStructuredReport (OHIF#2038)

fixes OHIF#1714

Call getInstanceCount() instead of manually checking length (which does not work)

Co-authored-by: Stefan Silviu <silviu.stefan@ab4.systems>

* chore(release): publish [skip ci]

 - @ohif/extension-vtk@1.7.8
 - @ohif/core@2.10.6
 - @ohif/viewer@4.5.15

Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
Co-authored-by: ohif-bot <danny.ri.brown+ohif-bot@gmail.com>
Co-authored-by: Alex Broaddus <alexbroaddus1@gmail.com>
Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com>
Co-authored-by: Rodolfo Ladeira <rodolfo_radical@hotmail.com>
Co-authored-by: Woonchan Cho <cronus17@gmail.com>
Co-authored-by: Woonchan Cho <wcho24@wustl.edu>
Co-authored-by: Nicolas Byl <nico@nicolas-byl.eu>
Co-authored-by: Ștefan Silviu-Alexandru <sylviu44@gmail.com>
Co-authored-by: Stefan Silviu <silviu.stefan@ab4.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use SeriesMetadata method instead of property Medicai-io/OHIF
1 participant
@akshaya999