Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race Condition when loading derived display sets. #1715

Closed
JamesAPetts opened this issue May 7, 2020 · 0 comments · Fixed by #1718
Closed

Race Condition when loading derived display sets. #1715

JamesAPetts opened this issue May 7, 2020 · 0 comments · Fixed by #1718
Assignees
@igoroctaviano
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
IDC

Comments

@JamesAPetts
Copy link
Member

When we have multiple SEGs/RTSTRUCTs we intend to load the most recent by default.
However we start to load once the first set of metadata arrives. We need to wait until all series metadata is fetched.
@JamesAPetts JamesAPetts added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label May 7, 2020
@igoroctaviano igoroctaviano mentioned this issue May 8, 2020
Merged
5 tasks
igoroctaviano added a commit that referenced this issue May 8, 2020
@igoroctaviano
fix: 🐛 Fix race condition when loading derived display sets
beeee36 
When we have multiple SEGs/RTSTRUCTs we intend to load the most recent
by default.

BREAKING CHANGE: 🧨 However we start to load once the first set of metadata arrives. We need
to wait until all series metadata is fetched.

✅ Closes: #1715
@JamesAPetts JamesAPetts added this to Done in IDC via automation May 14, 2020
JamesAPetts added a commit that referenced this issue May 14, 2020
@igoroctaviano @JamesAPetts
fix: 🐛 Fix race condition when loading derived display sets (#1718)
b1678ce 
When we have multiple SEGs/RTSTRUCTs we intend to load the most recent
by default.

BREAKING CHANGE: 🧨 However we start to load once the first set of metadata arrives. We need
to wait until all series metadata is fetched.

✅ Closes: #1715

Co-authored-by: James Petts <jamesapetts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igoroctaviano igoroctaviano

Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
IDC
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Fix race condition when loading derived display sets OHIF/Viewers
2 participants
@igoroctaviano @JamesAPetts