Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Fusion_Viewport to allow displaySets to be changed #3502

Merged
merged 6 commits into from Jun 29, 2023

Conversation

Sofien-Sellami
Copy link
Contributor

Context

This pull request addresses an issue where the fusion viewport does not refresh and match correctly when dragging and dropping CT and PT displaySets. The problem arises because the volumes added do not share the same FrameOfReferenceUID. Additionally, the displaySetMatchDetail of the fusion viewport is not updated with the new displaySetInstanceUID, further exacerbating the issue.

Changes & Results

  • Modified the displaySetMatchDetail to update the displaySetInstanceUID with the appropriate value.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 5cbc6c5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/649dbd307394a900080f6f1a
😎 Deploy Preview https://deploy-preview-3502--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 5cbc6c5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/649dbd30bd16f0000830a0e5
😎 Deploy Preview https://deploy-preview-3502--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3502 (5cbc6c5) into master (b4dbe56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3502   +/-   ##
=======================================
  Coverage   42.81%   42.81%           
=======================================
  Files          82       82           
  Lines        1448     1448           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        665      665           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dbe56...5cbc6c5. Read the comment docs.

@wayfarer3130
Copy link
Contributor

Could you enable the series tray, but closed by default? That way we can test this. Also update the branch.

Copy link
Contributor

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

Copy link
Contributor

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, marked the wrong issue. Would like to see this with the series tray enabled but closed.
Dan approved this with it closed.

@salimkanoun
Copy link
Contributor

@wayfarer3130 he add the panel but the deploy preview is in a cancelled state, however it's workin locally

Copy link
Contributor

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - tested locally and it runs fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants