New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3424: broken link in the docs #3509
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3509 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
Thanks a lot! Question, have you tried the keyclock doc in v3 and it works? (didn't have time to try it yet) |
Had to fix a few links, like the |
Maybe I was not clear, did you followed the doc and were able to successfully add the keyclock to OHIF? |
Ohh! No, I have not had the chance to set up KeyCloak yet. |
I was afraid so too, so in case you did not try it, I rather remove the doc since I don't want to add a doc that doesn't work. Can your PR only include the fix for the broken link? |
This is fixing the broken link. |
sure, let's remove that and the keyclock dock for now |
Context
Fixes #3424
In the current version of the documentation, the "Nginx + Image Archive" page has a dead link to "user account control recipe".
The root cause is that the "user-account-control.md" file was not carried over to the current version of the documentation.
Changes & Results
Changes:
Results:
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment