Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(README.md): Acknowledge IDC (README.md) #1136 #3576

Merged
merged 2 commits into from Aug 16, 2023
Merged

Conversation

igoroctaviano
Copy link
Contributor

Context

#1136

Add acknowledgment of funding from the IDC project: "NCI Imaging Data Commons: contract number 19X037Q from Leidos Biomedical Research under Task Order HHSN26100071 from NCI."

Because the IDC project is funding some of the efforts for the OHIF developers, prioritizing the specific features as needed for IDC.

Changes & Results

  • Acknowledge IDC in the README.md

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit d1b4899
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64dcbe0e84ba3a00089c4aa3
😎 Deploy Preview https://deploy-preview-3576--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit d1b4899
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64dcbe0efd57930008ab2853
😎 Deploy Preview https://deploy-preview-3576--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igoroctaviano igoroctaviano added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label Aug 2, 2023
@igoroctaviano
Copy link
Contributor Author

@fedorov can you please review the changes?

@igoroctaviano igoroctaviano added this to In progress in IDC via automation Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #3576 (d1b4899) into master (19408c9) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3576   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbe7c5...d1b4899. Read the comment docs.

@igoroctaviano igoroctaviano self-assigned this Aug 2, 2023
@cypress
Copy link

cypress bot commented Aug 2, 2023

Passing run #3457 ↗︎

0 36 0 0 Flakiness 0

Details:

Merge branch 'master' into doc/issues-1136
Project: Viewers Commit: d1b4899f91
Status: Passed Duration: 03:17 💡
Started: Aug 16, 2023 12:22 PM Ended: Aug 16, 2023 12:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@fedorov
Copy link
Member

fedorov commented Aug 2, 2023

Thank you @igoroctaviano!

@igoroctaviano
Copy link
Contributor Author

@sedghi can you please review this one?

@sedghi sedghi merged commit ed0b01c into master Aug 16, 2023
12 of 13 checks passed
IDC automation moved this from In progress to Done Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
IDC
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants