fix: Integration test instability #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #3597 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
sedghi
reviewed
Aug 11, 2023
sedghi
reviewed
Aug 11, 2023
wayfarer3130
force-pushed
the
fix/unstable-e2e-test
branch
from
3a2676d
to
1f49886
Compare
wayfarer3130
commented
Aug 11, 2023
| } | ||
| }); | ||
| // This shouldn't be necessary, but seems to be. | ||
| cy.wait(250); |
There was a problem hiding this comment.
This shouldn't be necessary, but I don't quite know how to avoid it.
sedghi
approved these changes
Aug 11, 2023
|
I run it locally and works fine. |
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The integration changes are a bit unstable.
Changes & Results
Most of the change is to add a bit of delay, but there is a bit of cleanup in other places for letting the cache size default and adding the TG-18 test dataset.
Testing
Run the integration tests, they should pass consistently.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment