Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing checkbox export #3629

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

salimkanoun
Copy link
Contributor

Context

The checkbox component was not exported at the root of the ui package

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit bb5a1a1
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64f35db0799c05000890df06
😎 Deploy Preview https://deploy-preview-3629--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit bb5a1a1
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64f35db042ede40008b4ff06
😎 Deploy Preview https://deploy-preview-3629--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #3629 (bb5a1a1) into master (9045dda) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3629   +/-   ##
=======================================
  Coverage   41.94%   41.94%           
=======================================
  Files          79       79           
  Lines        1421     1421           
  Branches      341      341           
=======================================
  Hits          596      596           
  Misses        658      658           
  Partials      167      167           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d47dce...bb5a1a1. Read the comment docs.

@sedghi sedghi merged commit dd6a881 into OHIF:master Sep 6, 2023
9 of 10 checks passed
@salimkanoun salimkanoun deleted the missing-checkbox-export branch September 11, 2023 12:34
Sofien-Sellami pushed a commit to Sofien-Sellami/Viewers that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants