Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch 'master' of github.com:OHIF/Viewers into feat/preclinical-4d-base #3654

Merged
merged 145 commits into from Sep 18, 2023
Merged

Merge branch 'master' of github.com:OHIF/Viewers into feat/preclinical-4d-base #3654

merged 145 commits into from Sep 18, 2023

Conversation

lscoder
Copy link
Collaborator

@lscoder lscoder commented Sep 14, 2023 •
edited

Merged with master and fixed some issues after the merge. There are two commits that need to be reviewed as follow:

Sofien-Sellami and others added 30 commits July 7, 2023 11:30
@Sofien-Sellami
ui(InputNumber): adding label element in InputNumber Component and … (O…
5ab74f5 
…HIF#3501)
@ohif-bot
chore(version): version.json [skip ci]
5eaf616
@ohif-bot
chore(version): Update package versions [skip ci]
87f3615
@Sofien-Sellami
fix(tmtv): jumpToClick Tool for TMTV mode (OHIF#3525)
a3e7ff4
@ohif-bot
chore(version): version.json [skip ci]
bfa1b1c
@ohif-bot
chore(version): Update package versions [skip ci]
2e040d5
@m00n620
fix(cli): extension template (OHIF#3512)
453ff0b
@ohif-bot
chore(version): version.json [skip ci]
74acc02
@ohif-bot
chore(version): Update package versions [skip ci]
913264d
@jbocce
fix(Measurement tracking): Side panel study browser can now be closed…
c3cd265 
… and measurements are still tracked (OHIF#3530)
@ohif-bot
chore(version): version.json [skip ci]
c9eb025
@ohif-bot
chore(version): Update package versions [skip ci]
19418df
@jbocce
fix(Worklist): use the flexbox gap style property for spacing between…
7d286a0 
… mode buttons (OHIF#3532)
@ohif-bot
chore(version): version.json [skip ci]
11471e6
@ohif-bot
chore(version): Update package versions [skip ci]
93a009f
@jbocce
fix(PT measurement units): Use the modality unit that arrives from co…
18156bb 
…rnerstone3d instead of calculating the modality unit (again) here. (OHIF#3533)
@ohif-bot
chore(version): version.json [skip ci]
f3aa8a8
@ohif-bot
chore(version): Update package versions [skip ci]
265c1fb
@wayfarer3130
chore(test): Integration test wait until rendered/queried instead of …
030e1e4 
…timed (OHIF#3540)
@ohif-bot
chore(version): version.json [skip ci]
839923e
@ohif-bot
chore(version): Update package versions [skip ci]
b904ea0
@wayfarer3130
Fix the wrong aspect ratio load (OHIF#3534)
d5cbbb0
@ohif-bot
chore(version): version.json [skip ci]
32bb553
@ohif-bot
chore(version): Update package versions [skip ci]
6d88978
@jbocce
feat(DataSource): Allow for dynamic data source configuration and cre…
7bbc213 
…ation (OHIF#3543)
@ohif-bot
chore(version): version.json [skip ci]
783bab7
@ohif-bot
chore(version): Update package versions [skip ci]
09a3022
@sedghi
fix(oauth): handle no user scenario (OHIF#3556)
81ab527
@ohif-bot
chore(version): version.json [skip ci]
2645e3c
@ohif-bot
chore(version): Update package versions [skip ci]
72933af
sedghi and others added 24 commits September 6, 2023 14:09
@sedghi
fix(hotkeys): preserve hotkeys if changed, and reduce re-rendering (O…
94f7cfb 
…HIF#3635)
@ohif-bot
chore(version): version.json [skip ci]
908fb8e
@ohif-bot
chore(version): Update package versions [skip ci]
6dd74b6
@jbocce
docs(google cloud healthcare): Added recipe docs for setting up Googl…
a6e668f 
…e Cloud Healthcare API (OHIF#3641)
@ohif-bot
chore(version): version.json [skip ci]
12acc39
@ohif-bot
chore(version): Update package versions [skip ci]
c158279
@jbocce
chore(prettier): fix end-of-line warnings (OHIF#3642)
de0a742
@ohif-bot
chore(version): version.json [skip ci]
3cc35e7
@ohif-bot
chore(version): Update package versions [skip ci]
2a77871
@lokeshnano
chore(gitignore): add vercel ignore (OHIF#3640)
c0fb2b4
@ohif-bot
chore(version): version.json [skip ci]
3e73ddf
@ohif-bot
chore(version): Update package versions [skip ci]
ca19bae
@jbocce
fix(suv): import calculate-suv library version that prevents SUV calc…
0d10f46 
…ulation for a zero PatientWeight (OHIF#3638)
@ohif-bot
chore(version): version.json [skip ci]
7f683a3
@ohif-bot
chore(version): Update package versions [skip ci]
64079e0
@yarikoptic
docs(spelling): Add codespell config + github action, run and fix a g…
11ca5b6 
…ood number of typos (OHIF#3645)
@ohif-bot
chore(version): version.json [skip ci]
15e1af2
@ohif-bot
chore(version): Update package versions [skip ci]
7eda0c5
@IbrahimCSAE
fix(health imaging): studies not loading from healthimaging if imagep…
74e62a1 
…ositionpatient is missing (OHIF#3646)
@ohif-bot
chore(version): version.json [skip ci]
fd74e46
@ohif-bot
chore(version): Update package versions [skip ci]
bd7f959
@lscoder
Merge branch 'master' of github.com:OHIF/Viewers into feat/preclinica…
4144158 
…l-4d-base
@lscoder
fixed some issues after merging with master branch
0fbcba8
@lscoder
fixed merge issues (viewportIndex to viewportId)
6332d6a
@lscoder lscoder requested a review from sedghi September 14, 2023 15:24
@lscoder lscoder self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #3654 (6332d6a) into feat/preclinical-4d-base (3e58deb) will decrease coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feat/preclinical-4d-base    #3654      +/-   ##
============================================================
- Coverage                     42.75%   41.88%   -0.88%     
============================================================
  Files                            82       79       -3     
  Lines                          1450     1423      -27     
  Branches                        338      341       +3     
============================================================
- Hits                            620      596      -24     
+ Misses                          667      660       -7     
- Partials                        163      167       +4

see 33 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e58deb...6332d6a. Read the comment docs.

@sedghi
Copy link
Member

sedghi commented Sep 18, 2023

Thanks a lot

@sedghi sedghi merged commit 89da236 into OHIF:feat/preclinical-4d-base Sep 18, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees

@lscoder lscoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet