Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worklist): new investigational use text #3999

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Mar 21, 2024

Context

Addresses #3916

Changes & Results

Added a new investigational use dialog component
New configuration option investigationalUseDialog

Screenshot

image

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit ce86f1a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66019496615c7e000886ee27
😎 Deploy Preview https://deploy-preview-3999--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi March 21, 2024 04:07
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6601976b846d9b00aba71285
😎 Deploy Preview https://deploy-preview-3999--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (8a335bd) to head (ce86f1a).
Report is 260 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3999      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70aae3...ce86f1a. Read the comment docs.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments thanks

@IbrahimCSAE IbrahimCSAE requested a review from sedghi March 25, 2024 12:13
@IbrahimCSAE
Copy link
Collaborator Author

ready to be merged

@sedghi sedghi merged commit 45b68e8 into master Mar 25, 2024
8 of 11 checks passed
edcheyjr pushed a commit to edcheyjr/Viewers that referenced this pull request Apr 7, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants