Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MetaDataProvider): Fix tag in GeneralImageModule #4000

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jlopes90
Copy link
Contributor

@jlopes90 jlopes90 commented Mar 21, 2024

Context

cornerstonejs/cornerstone3D#1165

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 7e76125
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/65fc5810c03e700008b43a64
😎 Deploy Preview https://deploy-preview-4000--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 7e76125
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/65fc58104fd08200080bf39d
😎 Deploy Preview https://deploy-preview-4000--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (8a335bd) to head (7e76125).
Report is 260 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70aae3...7e76125. Read the comment docs.

@sedghi sedghi merged commit e9c30a1 into OHIF:master Apr 10, 2024
6 of 8 checks passed
@jlopes90 jlopes90 deleted the fix-tag-in-general-image-module branch April 10, 2024 14:46
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants