feat(advanced-roi-tools): new tools and icon updates and overlay bug fixes #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #3793 ↗︎
Details:
Review all test suite changes for PR #4014 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4014 +/- ##
==========================================
- Coverage 46.23% 44.37% -1.87%
==========================================
Files 78 80 +2
Lines 1276 1334 +58
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 589 +41
- Partials 138 153 +15 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
IbrahimCSAE
changed the title
sedghi
reviewed
Apr 4, 2024
| @@ -124,7 +124,7 @@ const moreTools = [ | |||
| evaluate: 'evaluate.viewportProperties.toggle', | |||
| }), | |||
| createButton({ | |||
| id: 'Probe', | |||
| id: 'DragProbe', | |||
There was a problem hiding this comment.
why are you changing this? Probe is fine
sedghi
reviewed
Apr 4, 2024
| @@ -124,7 +124,7 @@ const moreTools = [ | |||
| evaluate: 'evaluate.viewportProperties.toggle', | |||
| }), | |||
| createButton({ | |||
| id: 'Probe', | |||
| id: 'DragProbe', | |||
sedghi
reviewed
Apr 4, 2024
| @@ -212,7 +212,7 @@ const toolbarButtons: Button[] = [ | |||
| evaluate: 'evaluate.viewportProperties.toggle', | |||
| }), | |||
| createButton({ | |||
| id: 'Probe', | |||
| id: 'DragProbe', | |||
sedghi
reviewed
Apr 4, 2024
| @@ -32,7 +32,7 @@ const ToolbarButton = ({ | |||
| ? toolTipClassName | |||
| : sizeToUse === 'toolbar' | |||
| ? 'w-[40px] h-[40px]' | |||
| : 'w-[32px] h-[32px]'; | |||
| : 'w-[40px] h-[40px]'; | |||
sedghi
approved these changes
Apr 5, 2024
edcheyjr
pushed a commit
to edcheyjr/Viewers
that referenced
this pull request
Apr 7, 2024
thanh-nguyen-dang
pushed a commit
to uc-cdis/Viewers
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes
#3819
#3721
Changes & Results