Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewport): Reset viewport state and fix CINE looping, thumbnail resolution, and dynamic tool settings #4037

Merged
merged 32 commits into from
Apr 16, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 15, 2024

💯 💯 💯 💯
This PR includes the addition of the OHIF DICOM Conformant Statement, generously made open source by Radical Imaging. We truly appreciate their contribution and dedication to open-source initiatives.
💯 💯 💯 💯

Context

Fixed reset of the viewports state when custom layout

After the user moves to a hanging protocol via presets (mpr, fourUp) there was no way to go back to simple stack viewport on drag and drop. This PR introduces a new state called isHangingProtocolLayout in viewportGrid where it makes the viewports start fresh if they are not in the hanging protocol mode


**Fixed CINE playing infinitely **


Fixed low resolution thumbnails


Made Add New Segmentation and the MPR layouts dynamically re-calculated

CleanShot 2024-04-15 at 23 22 32@2x


adds ability to directly run commands in the tool settings of the toolbar buttons in your modes

{
      name: 'Threshold',
      type: 'radio',
      id: 'dynamic-mode',
      value: 'ThresholdRange',
      values: [
        { value: 'ThresholdDynamic', label: 'Dynamic' },
        { value: 'ThresholdRange', label: 'Range' },
      ],
      commands: ({ value, commandsManager }) => {
        if (value === 'ThresholdDynamic') {
          commandsManager.run('setToolActive', {
            toolName: 'ThresholdCircularBrushDynamic',
          });
        } else {
          commandsManager.run('setToolActive', {
            toolName: 'ThresholdCircularBrush',
          });
        }
      },
    },

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

…sx, OHIFCornerstoneSEGViewport.tsx, OHIFCornerstoneSRViewport.tsx, and TrackedCornerstoneViewport.tsx
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit a2e431a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/661e8a24946c310008f1106f
😎 Deploy Preview https://deploy-preview-4037--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a2e431a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/661e8a249262eb0008d04390
😎 Deploy Preview https://deploy-preview-4037--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.37%. Comparing base (8a335bd) to head (a2e431a).
Report is 315 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4037      +/-   ##
==========================================
- Coverage   46.23%   44.37%   -1.87%     
==========================================
  Files          78       80       +2     
  Lines        1276     1334      +58     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      589      +41     
- Partials      138      153      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 15, 2024

Passing run #3832 ↗︎

0 43 0 0 Flakiness 0

Details:

Merge branch 'docs/apirl-2024' of github.com:OHIF/Viewers into docs/apirl-2024
Project: Viewers Commit: a2e431ad11
Status: Passed Duration: 06:27 💡
Started: Apr 16, 2024 2:44 PM Ended: Apr 16, 2024 2:51 PM

Review all test suite changes for PR #4037 ↗︎

@IbrahimCSAE IbrahimCSAE self-requested a review April 16, 2024 12:00
@sedghi sedghi changed the title Docs/apirl 2024 fix(viewport): Reset viewport state and fix CINE looping, thumbnail resolution, and dynamic tool settings Apr 16, 2024
@sedghi sedghi merged commit f99a0bf into master Apr 16, 2024
9 of 10 checks passed
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants