Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugs): enhancements and bug fixes - more #4043

Merged
merged 18 commits into from
Apr 17, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Apr 17, 2024

Issue 77: Not correct left/right padding for toolbar tool list
Issue 78: incorrect style for toolbox, fix rounded corners
Issue 81: fix layout shift in toolbar tool list
Issue 82: dicom tag browser width
Issue 83: fix outline touching the width for segmentation settings and 4d
Issue 84: fix LIGHTING spacing
Issue 85: 4D Tooltips
Issue 86: segmentation icons (eye, color) padding corrected
Issue 87: correct spacing for tmtv buttons
Issue 89: correct spacing for action menu
Issue 91: align modality text
Issue 94: colorbar gets reset on drag drop fixed

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 94c7079
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66201794b0ba9200087b47bf

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 94c7079
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/662017945aa1d60008db99bb

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.37%. Comparing base (d3cdfd8) to head (c980980).

❗ Current head c980980 differs from pull request most recent head 94c7079. Consider uploading reports for the commit 94c7079 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4043   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          80       80           
  Lines        1334     1334           
  Branches      327      327           
=======================================
  Hits          592      592           
  Misses        589      589           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi April 17, 2024 07:50
Copy link

cypress bot commented Apr 17, 2024

Passing run #3845 ↗︎

0 43 0 0 Flakiness 0

Details:

fix
Project: Viewers Commit: 94c7079670
Status: Passed Duration: 05:48 💡
Started: Apr 17, 2024 6:52 PM Ended: Apr 17, 2024 6:58 PM

Review all test suite changes for PR #4043 ↗︎

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-04-17 at 09 10 02@2x

@IbrahimCSAE IbrahimCSAE requested a review from sedghi April 17, 2024 17:41
@sedghi sedghi changed the title fix(bugs): enhancements and bug fixes fix(bugs): enhancements and bug fixes - more Apr 17, 2024
@sedghi sedghi merged commit 3754c22 into master Apr 17, 2024
7 checks passed
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 19, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants