Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Documentation): Fix wrong link for the components library in the architecture.md #4045

Conversation

pavel-kaiko
Copy link
Contributor

@pavel-kaiko pavel-kaiko commented Apr 17, 2024

Context

Current link in the documentation leads to the page with doesn't exist – https://react.ohif.org/, the proper URL is https://ui.ohif.org/

Changes & Results

Testing

Open https://deploy-preview-4045--ohif-platform-docs.netlify.app/development/architecture#ohifui and click the Check out our component library! link

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: N/A
  • Node version: N/A
  • Browser: N/A

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit ca0fcfd
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6621307b72d10d00087db820
😎 Deploy Preview https://deploy-preview-4045--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit ca0fcfd
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6621307ab142010008a5fa76
😎 Deploy Preview https://deploy-preview-4045--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (8a335bd) to head (ca0fcfd).
Report is 327 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   46.23%   44.57%   -1.66%     
==========================================
  Files          78       80       +2     
  Lines        1276     1328      +52     
  Branches      312      325      +13     
==========================================
+ Hits          590      592       +2     
- Misses        548      585      +37     
- Partials      138      151      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sedghi sedghi merged commit 1a01390 into OHIF:master Apr 18, 2024
5 of 7 checks passed
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 19, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants