Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layouts): and fix thumbnail in touch and update migration guide for 3.8 release #4052

Merged
merged 21 commits into from
Apr 19, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 18, 2024

  • Fix styling issue in DynamicDataPanel and remove unused code in tmtv mode
  • Add support for displaySetFromUrl in defaultRouteInit.ts
  • Add support for dynamic threshold brush in segmentationButtons.ts
  • Refactor measurement display string formatting in CircleROI, RectangleROI, and EllipticalROI
  • Fix reuseDisplaySetUID logic in HangingProtocolService.ts
  • Add support for dynamic threshold brush shape in segmentationButtons.ts
  • Refactor measurement display string formatting in CircleROI, RectangleROI, EllipticalROI, and SplineROI
  • Refactor toolbar event registration in cornerstone extension
  • Add max3DTextureSize to appConfigState in App.tsx and pass appConfig to isDisplaySetReconstructable function in getDisplaySetInfo.js
  • Refactor toolbar event registration in cornerstone extension
  • Refactor Thumbnail component styles and remove unused margin style
  • Refactor Thumbnail and ThumbnailNoImage components to handle double tap events on touch devices
  • Update button labels and tooltips for zoom-in and magnify probe tools
  • Update migration guide for OHIF Viewer 3.8 release
  • Add AdvancedMagnifyTool to initCornerstoneTools.js
  • cs3d upgrade

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

…to isDisplaySetReconstructable function in getDisplaySetInfo.js
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 4542fd6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6621dfeecf190800082e7d6c

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 4542fd6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6621dfeeadbe4000088f0be2
😎 Deploy Preview https://deploy-preview-4052--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title 3p8 rc1 again fix(layouts): and Refactor Thumbnail component and update migration guide for 3.8 release Apr 18, 2024
@sedghi sedghi changed the title fix(layouts): and Refactor Thumbnail component and update migration guide for 3.8 release fix(layouts): and fix thumbnail in touch and update migration guide for 3.8 release Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 44.41%. Comparing base (8a335bd) to head (4542fd6).
Report is 330 commits behind head on master.

Files Patch % Lines
...form/core/src/utils/isDisplaySetReconstructable.js 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4052      +/-   ##
==========================================
- Coverage   46.23%   44.41%   -1.83%     
==========================================
  Files          78       80       +2     
  Lines        1276     1333      +57     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      588      +40     
- Partials      138      153      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 18, 2024

2 failed tests on run #3850 ↗︎

2 41 0 0 Flakiness 0

Details:

Fix hanging protocol toggle registration in init.ts
Project: Viewers Commit: 4542fd686c
Status: Failed Duration: 06:28 💡
Started: Apr 19, 2024 3:19 AM Ended: Apr 19, 2024 3:26 AM
Failed  study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > maintains MRN filter upon return from viewer Test Replay Screenshots Video
Failed  customization/HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should navigate next/previous stage Test Replay Screenshots Video

Review all test suite changes for PR #4052 ↗︎

@sedghi sedghi merged commit d250d04 into master Apr 19, 2024
6 of 10 checks passed
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 19, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant