You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first layout defined, and currently applied has more than one stage and the second or later stages is applied, then the layout selector throws an exception on attempting to change layouts.
Changes & Results
Just set the stage index to 0 on changing protocol
All modified and coverable lines are covered by tests ✅
Project coverage is 44.41%. Comparing base (8a335bd) to head (b412aa8).
Report is 336 commits behind head on master.
❗ Current head b412aa8 differs from pull request most recent head 48e0152. Consider uploading reports for the commit 48e0152 to get more accurate results
sedghi
changed the title
fix: Fails to display any layouts in the layout selector if first layout has multiple stages
fix(hp): Fails to display any layouts in the layout selector if first layout has multiple stages
Apr 22, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
If the first layout defined, and currently applied has more than one stage and the second or later stages is applied, then the layout selector throws an exception on attempting to change layouts.
Changes & Results
Just set the stage index to 0 on changing protocol
Testing
Use the URL
http://localhost:3000/basic-test?StudyInstanceUIDs=2.16.124.113543.6004.101.103.20021117.061159.1&hangingProtocolId=@ohif/mnGrid
on a yarn test:e2e:serve
Click comma to navigate to stage index 1 (2cd stage)
Try to change to 3x2 layout
Currently goes black with an exception, expected behaviour is to go to 3x2 layout.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment