Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hp): Fails to display any layouts in the layout selector if first layout has multiple stages #4058

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

wayfarer3130
Copy link
Contributor

Context

If the first layout defined, and currently applied has more than one stage and the second or later stages is applied, then the layout selector throws an exception on attempting to change layouts.

Changes & Results

Just set the stage index to 0 on changing protocol

Testing

Use the URL
http://localhost:3000/basic-test?StudyInstanceUIDs=2.16.124.113543.6004.101.103.20021117.061159.1&hangingProtocolId=@ohif/mnGrid
on a yarn test:e2e:serve
Click comma to navigate to stage index 1 (2cd stage)
Try to change to 3x2 layout

Currently goes black with an exception, expected behaviour is to go to 3x2 layout.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 48e0152
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66266ac0fb56890008ec2b19

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 48e0152
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66266ac0f2b8d20008c4d348

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (8a335bd) to head (b412aa8).
Report is 336 commits behind head on master.

❗ Current head b412aa8 differs from pull request most recent head 48e0152. Consider uploading reports for the commit 48e0152 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4058      +/-   ##
==========================================
- Coverage   46.23%   44.41%   -1.83%     
==========================================
  Files          78       80       +2     
  Lines        1276     1333      +57     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      588      +40     
- Partials      138      153      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 22, 2024

1 failed test on run #3854 ↗︎

1 42 0 0 Flakiness 0

Details:

Fix integration test
Project: Viewers Commit: 48e0152d09
Status: Failed Duration: 06:15 💡
Started: Apr 22, 2024 2:01 PM Ended: Apr 22, 2024 2:07 PM
Failed  cypress/integration/study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > maintains MRN filter upon return from viewer Test Replay Screenshots Video

Review all test suite changes for PR #4058 ↗︎

@sedghi sedghi changed the title fix: Fails to display any layouts in the layout selector if first layout has multiple stages fix(hp): Fails to display any layouts in the layout selector if first layout has multiple stages Apr 22, 2024
@sedghi sedghi merged commit f0ed3fd into master Apr 22, 2024
6 of 7 checks passed
@wayfarer3130 wayfarer3130 deleted the fix/hp-fails-to-apply branch April 22, 2024 14:00
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 30, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants